Open in new window / Try shogun cloud
--- Log opened Tue Jul 26 00:00:38 2016
-!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]00:34
-!- GandalfTheWizard [~Emma@112.10.170.216] has joined #shogun00:48
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has joined #shogun04:14
-!- GandalfTheWizard [~Emma@112.10.170.216] has quit [Ping timeout: 240 seconds]04:29
@wikingOXPHOS: if you are touching CHAIDTree05:13
@wikingdo you mind to fix a bug there?05:13
OXPHOSwiking: I can try05:14
@wikingOXPHOS: lemme dig it out05:14
@wikingOXPHOS: one is rather simple: http://buildbot.shogun-toolbox.org/static_analysis/2016-07-13-010034-30511-1/report-e95725.html#EndPath05:16
OXPHOSwiking: not sure how to read it..what is the problem there?05:20
@wikingsee the 5 steps05:20
@wikingit basically describe you a situation05:21
@wikingwhere you gonna have a null pointer exception05:21
@wikingwhen you do CDynamicObjectArray* children=node->get_children();05:21
@wikingcoz05:21
@wikingnode_t* node=current05:21
@wikingbut there's never a check whether current != NUL05:21
@wikingL05:21
@wikinggot it?05:21
OXPHOSso there could be situation when current=NULL05:22
OXPHOSjust we need a check there05:22
OXPHOSwiking^05:23
@wikingyeah i mean the easiest is that you add an assertation05:24
@wikingin the beginning of the function call of CLabels* CCHAIDTree::apply_from_current_node(SGMatrix<float64_t> fmat, node_t* current)05:24
@wikingthat current != NULL05:24
@wikingit's a simple input value check for the function05:26
OXPHOSwiking: kk i see05:27
OXPHOSwiking: and for the sgvector serialization - any comments on the refcount? https://github.com/shogun-toolbox/shogun/pull/322605:28
@wikingyeah i'm gonna look into that now05:28
@wikingok so another thing is05:28
@wikingcan you login here: https://scan.coverity.com05:28
@wikingwith your github accoutn?05:28
OXPHOSwiking: "You are not associated with any projects"05:29
OXPHOSIn order to start using Scan you need to be associated with at least one project.05:30
@wikingah05:30
@wikingcan you tell me what is your email address associated with your github account?05:30
OXPHOSengelzora@gmail.com05:30
OXPHOSI can do "add me to the project"05:31
@wikingsend you an invite05:31
OXPHOSwiking: thx. I logged in.05:34
@wikingok can u see now the shogun project?05:34
@wikingyou should be able to view the defects05:34
@wikingi wonder if you can open this link: https://scan8.coverity.com/reports.htm#v11736/p10202/fileInstanceId=12508917&defectInstanceId=4294867&mergedDefectId=13594505:35
@wikingbut once you can go to the defects you should try to look at the 135945 CID05:35
@wikingthat's the CHAID related resource leak05:35
@wikingthe thing is that it's rather complicated :)05:35
@wikingOXPHOS: so ok for sgvect05:37
@wikingso the thing is that we serialize the sgvec as part of a model right?05:37
OXPHOSyep05:37
@wikingsay i have a LinearMachine that has a weight vector05:37
@wikingSGVector<float64_t>05:37
@wikingw05:37
@wikingso you need to serialize the refcount structure05:38
@wikingbecause in this case there would be refcount = 105:38
@wikingbut thin kabout a more complicated model05:38
OXPHOSlike?05:41
OXPHOSbtw I saw the leaks05:42
@wikingwhat do yo umean lik?05:42
@wiking*like05:42
OXPHOSoh I was waiting for your example about the "more complicated model"05:43
OXPHOSwiking^05:43
@wikingwell more complicated can be05:45
@wikingthat you have some Label vector05:45
@wikingand say those are referenced my the machines in the bagging machine05:46
@wikingbagging machine like RF05:46
@wikingso that label vector would have like05:47
@wikingrefcount = as many trees there are in RF05:47
OXPHOSyeah..05:48
@wikingso yeah you have to set serialize the ref count05:48
@wikingat least the count05:48
OXPHOSokay. yeah i was thinking i have to05:51
@wikinglike i twas in the old serialization case right?05:51
OXPHOSright05:52
OXPHOSlemme see how to do this inheritance serialization05:52
@wikingmmm i mean you dont need to serialize the SGRef object itself05:55
@wikingbut yeah05:56
@wikingthat's one way05:56
OXPHOSwiking: I just need the m_refcount, i.e. RefCount class right? but m_refcount is private in SGRef. so I guess I have to go through SGRef06:02
@wikingOXPHOS: i mean the best is if you actually serialize the inherited things automatically06:05
@wikingif possible06:05
@wikingbecause that way if later there's a change in SGReferencedData then we dont need to modify anything in the serialization code06:05
@wikingand you need to go through SGReferencedData06:05
@wiking"class SGVector : public SGReferencedData"06:06
@wikingOXPHOS: http://uscilab.github.io/cereal/polymorphism.html06:07
@wiking^ that's your howto06:07
@wikingmmm06:08
@wikingwait maybe not enough06:08
@wikingbut yeah you can define releation like06:08
@wikingCEREAL_REGISTER_POLYMORPHIC_RELATION(SGVector, SGReferencedData)06:08
@wikingCEREAL_REGISTER_POLYMORPHIC_RELATION(SGMatrix, SGReferencedData)06:09
@wikingRefCount is just a member of SGReferencedData06:09
@wikingbut yeah i guess that'd need a serialization method as well :)06:09
@wikingbtw06:10
OXPHOSsaw it . thanks!06:10
@wikingOXPHOS: http://uscilab.github.io/cereal/inheritance.html06:10
@wikingbut yeah06:10
@wikingi have a question06:10
@wikingso the template<Archive> save/load_cereal(Archive& a) methods are currently implemented in cpp06:11
@wikingright?06:11
OXPHOSyes06:11
OXPHOSfor sgobject06:11
OXPHOSit's in sgvector.h06:11
@wikingOXPHOS: yep yep i mean sgobject06:12
@wikingwould it be hard to move it to sgobject.h?06:12
@wikingbecause the problem is that even if you expose now the templated version of the save/load thingy06:12
@wikingthe user will have to recompile shogun06:12
@wikingif she wants to serialize it into a new Archive format06:12
@wikingright?06:12
OXPHOSI think all existed/specified formats will be compiled in the begining?06:13
@wikingok so let me put it this way06:14
OXPHOSthe only solution i can see is to move the SGObejct::self from .cpp to .h. Not sure how bazdback like this06:14
@wikingthere are now 3 formats06:14
@wikingright?06:14
OXPHOSyes06:14
@wikingso what if i have a new Archive format06:14
@wikinga custom one06:14
@wikingbecause i'm a user like that06:14
@wikingand i wanna use that for serializing shogun06:15
@wikingobjects06:15
OXPHOSYeah the codes has to be modified and everything will be re-compiled because it's SGObejct06:15
@wikingin that case the only option is that actually i make that part of shogun06:15
@wiking(the new format)06:15
@wikingand then i need to recompile06:16
@wikingok so but if the templated load/save would be implemented in header06:16
@wikingthis coudl be avoided right?06:16
OXPHOSI think so06:17
OXPHOSyeah right06:17
@wikingok so06:18
@wikingthe question is06:18
@wikingwhat is preventing us to be able to do this switch?06:19
OXPHOSI need to iterate through the map, which is defined in .cpp06:21
OXPHOSit's in a pimpl06:21
OXPHOSwiking^06:22
@wikingParametersMap?06:24
OXPHOSwiking^ yes..it's self::map[basetag, any]06:26
@wikingok i suppose we dont want to expose the self in .h because of map/unordered_map06:30
@wikingbut lemme ask about this bazdback06:30
@wiking:)06:30
OXPHOSkk06:31
@wikingso lets not merge that until we can resolve that either way06:32
@wiking:p06:32
@wikingi guess 12 hours more max06:32
-!- sanuj [~sanuj@117.204.242.64] has joined #shogun06:42
-!- sanuj [~sanuj@117.204.242.64] has quit [Ping timeout: 260 seconds]07:08
-!- shogun-notifier- [~irker@7nn.de] has joined #shogun07:15
shogun-notifier-shogun: Wu Lin :develop * f49f873 / cmake/FindMetaExamples.cmake: https://github.com/shogun-toolbox/shogun/commit/f49f8731ef0c0256b79b104ea916f37138ea2d3707:15
shogun-notifier-shogun: fix a bug in cmake07:15
shogun-notifier-shogun: Wu Lin :develop * f3485af / cmake/FindMetaExamples.cmake: https://github.com/shogun-toolbox/shogun/commit/f3485af3f9bbce846d0c6f1cd013b09c25e53d2407:15
shogun-notifier-shogun: Merge pull request #3394 from yorkerlin/bugfix07:15
shogun-notifier-shogun:07:15
shogun-notifier-shogun: fix a bug in cmake07:15
shogun-buildbotbuild #1309 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1309  blamelist: Wu Lin <yorkerlin@users.noreply.github.com>, Wu Lin <yorker.lin@gmail.com>07:17
shogun-buildbotbuild #2951 of bsd1 - libshogun is complete: Failure [failed configure]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2951  blamelist: Wu Lin <yorkerlin@users.noreply.github.com>, Wu Lin <yorker.lin@gmail.com>07:26
shogun-buildbotbuild #88 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/88  blamelist: Wu Lin <yorkerlin@users.noreply.github.com>, Wu Lin <yorker.lin@gmail.com>07:56
shogun-buildbotbuild #38 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/38  blamelist: Wu Lin <yorkerlin@users.noreply.github.com>, Wu Lin <yorker.lin@gmail.com>08:05
-!- sanuj [~sanuj@117.204.242.64] has joined #shogun08:06
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has quit [Ping timeout: 250 seconds]08:22
@wikingbazdback: ping ping pingoooo ping08:50
@wiking:)08:50
sanuji need you too bazdback08:52
shogun-notifier-shogun: Viktor Gal :develop * 6249e61 / cmake/FindCtags.cmake: https://github.com/shogun-toolbox/shogun/commit/6249e61b211c667f7ca02bc29f802644bc7cfa1208:52
@wikingsanuj: what do you nneed?08:52
shogun-notifier-shogun: Prefer Exuberant Ctags over GNU08:52
shogun-notifier-shogun: this fixes the problem of FreeBSD's ctags08:52
@wikingi might be able to help08:53
sanujwiking, he suggested me to use sfinae to solve the plugin bug08:53
@wikingah08:53
sanuji have read about sfinae and understand it a bit08:54
@wiking yeah and wher ehave you got stuck with it?08:54
sanujbut not sure how to solve that bug using sfinae08:54
@wikingi mean sfinae is all about not erroring when there's an unsupported type08:54
sanujwiking, https://travis-ci.org/shogun-toolbox/shogun/jobs/147180067#L139408:54
@wikingjust simply silently NOP08:54
shogun-buildbotbuild #1310 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1310  blamelist: Viktor Gal <viktor.gal@maeth.com>08:55
@wikingsanuj: btw do you know of a good substitution for std::hash in none-c++11 case?08:55
@wikingyou mean this08:55
@wiking/opt/shogun/src/shogun/lib/any.h:149:34: error: no match for 'operator==' (operand types are 'std::function<shogun::Some<shogun::MockBaseClass>()>' and 'std::function<shogun::Some<shogun::MockBaseClass>()>')08:55
@wiking?08:56
sanujyeah08:56
sanujbut i'm not comparing std::function anywhere explicitly08:56
@wikingwhat do you compare then?08:57
@wikingi know that you do a08:57
@wikingASSERT_EQ()08:57
@wikingright?08:57
sanujEXPECT_EQ08:58
@wikingor that08:58
@wikingyeah08:58
sanujwiking, but the compiler error is not from there08:58
@wikingbtw08:58
@wikingin any.h08:58
@wiking#include <string.h>08:58
sanujwiking, it happens while compiling this https://github.com/shogun-toolbox/shogun/pull/3370/files#diff-7e05729c8a117ab30510a77a08865f33R108:58
@wikingshouldn't that be <cstring>08:58
@wikingto be correct?08:59
sanujwiking, actually yes, i'll fix that08:59
@wikingk08:59
sanujwiking, but how to go about debugging this09:00
sanujhow to use sfinae09:00
sanujis it for debugging or preventing the bug from happening?09:00
@wikinglatter09:00
@wikingi mean you wanna be able to compile this code09:00
@wiking            return typed_storage == typed_other_storage;09:01
@wikinghere typed_storage = std::function<shogun::Some<shogun::MockBaseClass>()>09:01
@wikingright?09:01
sanujyeah09:01
sanujwiking, so i need to use sfinae in any.h so that it compiles09:03
shogun-buildbotbuild #89 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/89  blamelist: Viktor Gal <viktor.gal@maeth.com>09:03
@wikingso can you just provide an empty implementation for that?09:05
@wikingi mean the specialized case of any template09:05
shogun-buildbotbuild #2952 of bsd1 - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2952  blamelist: Viktor Gal <viktor.gal@maeth.com>09:05
sanujwiking, okay, i see09:05
sanujwiking, so a specialized implementations for std::function?09:06
@wikingi mean i guess anything that is std::function<?>09:07
sanujoh yeah09:07
sanujcool, i'll try patching any09:07
shogun-buildbotbuild #39 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/39  blamelist: Viktor Gal <viktor.gal@maeth.com>09:42
-!- sanuj [~sanuj@117.204.242.64] has quit [Ping timeout: 258 seconds]09:48
shogun-notifier-shogun: Viktor Gal :develop * 515b334 / src/shogun/regression/LeastAngleRegression.h: https://github.com/shogun-toolbox/shogun/commit/515b3349560275e959aa459d8c5fd1d36d9a1f7810:12
shogun-notifier-shogun: Remove dependency for lapack in LARS10:12
-!- sanuj [~sanuj@117.204.242.64] has joined #shogun10:13
shogun-buildbotbuild #1311 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1311  blamelist: Viktor Gal <viktor.gal@maeth.com>10:14
shogun-buildbotbuild #90 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/90  blamelist: Viktor Gal <viktor.gal@maeth.com>10:24
shogun-buildbotbuild #2953 of bsd1 - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2953  blamelist: Viktor Gal <viktor.gal@maeth.com>10:26
shogun-notifier-shogun: Viktor Gal :develop * 14355ea / tests/unit/ (2 files): https://github.com/shogun-toolbox/shogun/commit/14355ea1b0baffe6b1eb8356000033bf5fa8144510:40
shogun-notifier-shogun: Include <numeric> when using std::iota10:40
shogun-buildbotbuild #1312 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1312  blamelist: Viktor Gal <viktor.gal@maeth.com>11:06
shogun-buildbotbuild #40 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/40  blamelist: Viktor Gal <viktor.gal@maeth.com>11:11
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has joined #shogun11:14
shogun-buildbotbuild #2954 of bsd1 - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2954  blamelist: Viktor Gal <viktor.gal@maeth.com>11:14
shogun-buildbotbuild #91 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/91  blamelist: Viktor Gal <viktor.gal@maeth.com>11:15
OXPHOSHey wiking, I was trying to #include <cereal/types/base_class.hpp>, but got the error halfway: http://pastebin.com/BYXbQVBN any idea why?11:16
@wikingjust a sec checking11:22
-!- OXPHOS_ [c0a906af@gateway/web/freenode/ip.192.169.6.175] has joined #shogun11:31
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has quit [Ping timeout: 250 seconds]11:33
@wikingshogun-buildbot: force build --branch=develop 'bsd1 - libshogun'11:51
shogun-buildbotbuild #2955 forced11:52
shogun-buildbotI'll give a shout when the build finishes11:52
shogun-buildbotbuild #2955 of bsd1 - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/295511:54
shogun-buildbotbuild #41 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/41  blamelist: Viktor Gal <viktor.gal@maeth.com>11:54
-!- lambday [8028b10a@gateway/web/freenode/ip.128.40.177.10] has joined #shogun12:00
-!- mode/#shogun [+o lambday] by ChanServ12:00
shogun-notifier-shogun: Viktor Gal :develop * 9273672 / cmake/FindMetaExamples.cmake: https://github.com/shogun-toolbox/shogun/commit/9273672ad3afa6d4ead25fbdadf2660b6cc8aeb812:00
shogun-notifier-shogun: Remove GMM meta example if LAPACK is not available12:00
@wikingOXPHOS_: mmm12:02
@wikingOXPHOS_: all you did is just to include the cereal/types/base_class12:02
@wiking.hpp:33:12:02
@wiking?12:02
OXPHOS_wiking: YES12:02
shogun-buildbotbuild #1313 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1313  blamelist: Viktor Gal <viktor.gal@maeth.com>12:03
@wiking:) upset? :)12:03
@wikingor why the capitals? :>12:03
OXPHOS_confused.. :P12:03
@wikingu r asian12:04
@wikingwhen u write with capitals12:04
@wikingpeople are super angry12:04
@wiking:)12:04
@wikingok so what's your cereal version?12:04
bazdbackBAZDMAAAGGGZZ12:06
@wikingbazdback: y012:07
@wikingOXPHOS_: ok so just to make sure12:07
@wikingif you take that example from http://uscilab.github.io/cereal/inheritance.html12:07
@wikingand do12:07
OXPHOS_wiking: sorry..i was angry about the error. should be 1.2.0 but I need to confirm12:07
@wikingclang++ -I/usr/local/include -std=c++11 -c test_cereal.cpp12:08
@wikingwhat happens?12:08
@wikingbazdback: morning12:08
OXPHOS_wiking: no error12:09
OXPHOS_wiking: compiled12:09
@wikingOXPHOS_: super :)12:09
shogun-buildbotbuild #92 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/92  blamelist: Viktor Gal <viktor.gal@maeth.com>12:11
@wikingOXPHOS_: btw include it before #include <shogun/lib/config.h>12:12
@wikingi mean the base clase12:12
@wiking*"class12:12
shogun-buildbotbuild #2956 of bsd1 - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2956  blamelist: Viktor Gal <viktor.gal@maeth.com>12:13
OXPHOS_lemme try12:14
OXPHOS_wiking: not helping12:16
OXPHOS_wiking: SVMLightOneClass.cpp is not the first .cpp includes base_class.hpp. I don't  know why the previous ones were fine12:17
bazdbackwiking: hey12:35
-!- bazdback is now known as lisitsyn12:35
@wikingho12:37
-!- travis-ci [~travis-ci@ec2-54-91-68-140.compute-1.amazonaws.com] has joined #shogun12:42
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/14742351612:42
-!- travis-ci [~travis-ci@ec2-54-91-68-140.compute-1.amazonaws.com] has left #shogun []12:42
shogun-buildbotbuild #42 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/42  blamelist: Viktor Gal <viktor.gal@maeth.com>12:50
-!- HeikoS [~heiko@smb-amrs-02.hotspot.hub-one.net] has joined #shogun12:51
-!- mode/#shogun [+o HeikoS] by ChanServ12:52
-!- HeikoS [~heiko@smb-amrs-02.hotspot.hub-one.net] has quit [Client Quit]12:56
OXPHOS_wiking: hey any updates? : )12:57
@wikingon my end?13:00
@wikingi dont have th ecode :)))13:01
@wikingOXPHOS_: i'm trying to fix some opaque shit in the mkl13:01
sanujwiking, you work on computer vision right?13:01
@wikingsanuj: used to13:01
@wikingnot lately13:01
@wikinglately i'm a fucking devops idiot13:01
@wiking:D13:01
sanujhaha13:02
sanujwiking, what's your phd on?13:02
OXPHOS_wiking: ohhhh any hints on how to debug? It literally requires nothing but #include <base_class.hpp> to cause the error13:04
sanujlisitsyn, there?13:11
@wikingsanuj: medical image processing13:12
@wikingOXPHOS_: what you can do13:12
@wikingis do a clang++ -E13:12
@wikingthat'll basically generate the whole file13:12
sanujwiking, i got an intern at this lab camp.lcsr.jhu.edu/intern/13:13
@wikingjhu is cool13:13
sanujthey do robotics and vision in medicine13:13
@wikingOXPHOS_: so with that (g++ or clang++) doesn't matter13:14
@wiking-E will just generate the file, i.e. resolve all the macros13:14
OXPHOS_wiking: thanks! lemme try13:16
OXPHOS_sanuj: congrats!13:16
sanujOXPHOS_, thanks :D13:16
sanujwiking, you know any online sources from where i can learn about vision stuff related to augmented reality?13:21
@wikingmmm13:21
@wikingscholar.google.com13:21
@wiking:)13:21
sanuj:D13:21
@wikingyou think i'm joking :)13:30
sanujnope :)13:34
@wikinglisitsyn: bazdmeg here?13:50
lisitsynwiking: yeap13:50
sanujlisitsyn, in any.h, i did this13:52
sanuj        bool equals(void** storage, void** other_storage) const13:52
sanuj        {13:52
sanuj            if(util::EqualExists<T>::value) {13:52
sanuj                T typed_storage = *(reinterpret_cast<T*>(*storage));13:52
sanuj                T typed_other_storage = *(reinterpret_cast<T*>(*other_storage));13:52
sanuj                return typed_storage == typed_other_storage;13:52
sanuj            }13:52
sanuj            return true;13:52
sanuj        }13:52
sanujwhere EqualExists checks if operator== is present13:52
lisitsyndoes it work?13:52
sanujno13:52
lisitsynI'd guess so13:52
lisitsyn:D13:52
sanujyeah13:52
sanujgives same compiler error13:53
@wikinglisitsyn: so question13:53
lisitsynquite obvious13:53
sanujlisitsyn, what exactly were you suggesting yesterday13:53
lisitsynwiking: what q?13:53
lisitsynsanuj: sfinae!13:54
lisitsynbool equals(void** storage, void** other_storage) const13:54
lisitsynthis should be different when it comes to T13:55
lisitsynthat doesn't support13:55
lisitsyn==13:55
sanujlisitsyn, so i just make another "equals" implementation which just returns true ?13:55
sanujyeah13:55
lisitsynsanuj: oh this is quite dangerous13:55
lisitsynI'd prefer keeping it unimplemented13:55
sanujlisitsyn, you don't want to  implement operator== for any?13:56
lisitsynsanuj: you'd need two declarations of operator==13:57
sanujor do i just declare a specialization of equals for std::function and not implement it?13:58
lisitsynsanuj: yeah rather that13:58
sanujbut is this sfinae?13:58
lisitsynbool equals(void** storage, void** other_storage, bool supports_equal=util::EqualExists<T>::value) const13:59
lisitsynI'd suggest something like that13:59
sanujlisitsyn, how will i use the supports_equal value in the function equals?14:00
lisitsynsanuj: you don't use it14:01
lisitsynyou just put default value there14:01
lisitsynso compiler chooses the right implementation14:01
sanujokay, let me try that14:02
sanujlisitsyn, is this function specialization based on its argument "supports_equal" rather than its template argument T?14:05
lisitsynyeap14:05
lisitsynor you can go with some other approach14:05
lisitsynnot sure which is best here14:05
sanujlisitsyn, i think it's good to check for the existence for operator==14:06
sanujlisitsyn, but if we leave it undefined for the cases when operator== doesn't exist then how will it decide whether it's equal or not?14:07
@wikinglisitsyn: so in order to be able to put the template implementation of the serialization function of SGObject into the header (that way no need to recompile the whole library if one comes up with a new Archive type14:08
@wikingthis requires self, i.e. the parameterMap to be defined in the header right?14:12
@wiking:)14:12
@wikinglisitsyn: ^14:17
@wikinglisitsyn: pingooooo14:37
sanujwiking, is it possible to do function specialization based on its argument "supports_equal" rather than its template argument T?14:41
-!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout]15:00
lisitsynwiking: sry15:04
-!- sanuj [~sanuj@117.204.242.64] has quit [Ping timeout: 264 seconds]15:14
@wikinglisitsyn: i stole your ::Self idea for MKL15:16
@wikingcare to look at it?15:16
@wiking:D15:16
@wikinglisitsyn: but yeah what do u say on the above15:16
-!- OXPHOS_ [c0a906af@gateway/web/freenode/ip.192.169.6.175] has quit [Ping timeout: 250 seconds]15:24
@wikingSaurabh7: ping15:30
lisitsynwiking: sry!15:41
lisitsyn:D15:41
lisitsyninterrupted all the time15:41
@wikinglisitsyn: okok so read those when u can and react15:41
@wiking(and comment on my pr)15:41
@wiking:D15:41
@wikinghttps://github.com/shogun-toolbox/shogun/pull/339615:42
@wikingi dont remember when was my last time15:42
@wikingthat i sent a pr15:42
lisitsynwiking: SELF!15:48
lisitsynall the way15:48
lisitsynwiking: well this looks good15:49
-!- sanuj [~sanuj@117.204.242.64] has joined #shogun15:49
lisitsynexactly what this is for15:49
@wikingok cool15:49
@wikingi'll wait for travis15:49
@wikingbut then i'll merge15:49
@wikinglisitsyn: but yeah any ideas about template<Archive>...?15:50
lisitsynwiking: yeah just read it but sorry don't really get the problem15:50
lisitsynis there some code?15:50
@wikingok so15:50
@wikinglemme find the pr15:50
@wikingok look here15:52
@wikinghttps://github.com/shogun-toolbox/shogun/pull/3375/files#diff-9c3599c0d2090e493be261b079e9b63eR52315:52
@wikingsee the template<class Archive> void CSGObject::cereal_save(Archive& ar) const; is implemented in .cpp15:52
@wikingso now this is a shit15:52
@wikingif somebody comes with a new Archive format15:52
@wikingnot the 3 default ones15:53
@wikingcereal::BinaryOutputArchive, cereal::JSONOutputArchive, cereal::XMLOutputArchive15:53
@wikingbecause if you specify a new serialization format15:53
@wikingthen you have to recompile shogun15:53
@wikingwhile if the templated save/load would be implemented in SGObject.h15:54
@wikingsee what i mean?15:54
lisitsynuh15:54
lisitsynso we want to support just any possible Archive?15:54
lisitsynI didn't know we do want it, now I get it15:54
lisitsynwiking: do we really want to support arbitrary Archives?15:55
@wikingi mean why not? :)15:56
@wikingi mean i dont care into what format the user wants to serialize15:56
@wikingif he want to serialize directly into memcached or redis15:56
@wikingi dont care15:56
@wikingif he implements the Archive interface he can do it15:57
lisitsynok I get it15:57
lisitsynwiking: ok we need to bridge the gap between templated archive15:57
lisitsynand hidden .cpp things15:57
lisitsynwiking: argh16:00
lisitsynthis is tough16:00
lisitsynwiking: I am not really a fan of what kind of rape happened to 'any'16:02
lisitsyn:D16:02
-!- shogun-notifier- [~irker@7nn.de] has joined #shogun16:05
shogun-notifier-shogun: OXPHOS :feature/cereal * b002f1e / src/shogun/base/SGObject.h,src/shogun/lib/any.h: https://github.com/shogun-toolbox/shogun/commit/b002f1ecffde34f87eff4657e391c289321927ee16:05
shogun-notifier-shogun: update indentations and whitespace16:05
shogun-notifier-shogun: Sergey Lisitsyn :feature/cereal * f95a0d7 / src/shogun/base/SGObject.h,src/shogun/lib/any.h: https://github.com/shogun-toolbox/shogun/commit/f95a0d73a2160d18ef0a8a6bed307972eda984a216:05
shogun-notifier-shogun: Merge pull request #3393 from OXPHOS/cereal_style16:05
shogun-notifier-shogun:16:05
-!- sanuj [~sanuj@117.204.242.64] has quit [Ping timeout: 240 seconds]16:05
shogun-notifier-shogun: update indentations and whitespace in SGObject and Any16:05
@wiking:>>>>16:07
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has joined #shogun16:08
lisitsynwiking: there must be prettier way to do that :D16:08
@wikinglisitsyn: mmmm16:10
shogun-notifier-shogun: Viktor Gal :develop * efd291f / src/shogun/classifier/mkl/MKL.cpp,src/shogun/classifier/mkl/MKL.h: https://github.com/shogun-toolbox/shogun/commit/efd291f4ac41ac4324dafd336694527ad683100416:23
shogun-notifier-shogun: Hide GPLK or CPLEX parameters16:23
shogun-notifier-shogun: this way one will not require to supply the compiler flags16:23
shogun-notifier-shogun: for GLPK or CPLEX when using MKL.16:23
shogun-notifier-shogun: Viktor Gal :develop * 9ef9147 / src/shogun/classifier/mkl/MKL.cpp,src/shogun/classifier/mkl/MKL.h: https://github.com/shogun-toolbox/shogun/commit/9ef91473de6cb005bcdd0e824bd1f5b9547f66bb16:23
shogun-notifier-shogun: Merge pull request #3396 from vigsterkr/MKLparams16:23
shogun-notifier-shogun:16:23
shogun-notifier-shogun: Hide GPLK or CPLEX parameters16:23
shogun-buildbotbuild #1314 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1314  blamelist: Viktor Gal <viktor.gal@maeth.com>16:25
shogun-buildbotbuild #1315 of precise - libshogun is complete: Failure [failed compile]  Build details are at http://buildbot.shogun-toolbox.org/builders/precise%20-%20libshogun/builds/1315  blamelist: Viktor Gal <vigsterkr@gmail.com>16:32
shogun-buildbotbuild #2957 of bsd1 - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/bsd1%20-%20libshogun/builds/2957  blamelist: Viktor Gal <vigsterkr@gmail.com>, Viktor Gal <viktor.gal@maeth.com>16:36
-!- sanuj [~sanuj@117.204.242.64] has joined #shogun16:59
shogun-buildbotbuild #43 of FC23 - libshogun - aarch64 is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/FC23%20-%20libshogun%20-%20aarch64/builds/43  blamelist: Viktor Gal <vigsterkr@gmail.com>, Viktor Gal <viktor.gal@maeth.com>17:19
-!- shogun-buildbot [~shogun-bu@7nn.de] has quit [Quit: buildmaster reconfigured: bot disconnecting]17:22
-!- shogun-buildbot [~shogun-bu@7nn.de] has joined #shogun17:22
-!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has joined #shogun17:28
shogun-buildbotbuild #93 of xenial - libshogun is complete: Failure [failed test]  Build details are at http://buildbot.shogun-toolbox.org/builders/xenial%20-%20libshogun/builds/93  blamelist: Viktor Gal <vigsterkr@gmail.com>, Viktor Gal <viktor.gal@maeth.com>17:29
-!- travis-ci [~travis-ci@ec2-54-158-129-129.compute-1.amazonaws.com] has joined #shogun17:36
travis-ciit's Viktor Gal's turn to pay the next round of drinks for the massacre he caused in shogun-toolbox/shogun: https://travis-ci.org/shogun-toolbox/shogun/builds/14748648617:36
-!- travis-ci [~travis-ci@ec2-54-158-129-129.compute-1.amazonaws.com] has left #shogun []17:36
-!- OXPHOS [c0a906af@gateway/web/freenode/ip.192.169.6.175] has quit [Quit: Page closed]17:46
c4goldswping wiking18:14
sanujlisitsyn, there?18:39
-!- lambday [8028b10a@gateway/web/freenode/ip.128.40.177.10] has quit [Quit: Page closed]19:02
-!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]19:04
-!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has joined #shogun19:07
CaBais there an implementation of any kind of weighted training in shogun? i.e. if i want to add a sort of confidence to a binary label?19:16
-!- shogun-notifier- [~irker@7nn.de] has quit [Quit: transmission timeout]19:23
c4goldswHey CaBa, try asking sanuj or Saurabh719:56
-!- sanuj [~sanuj@117.204.242.64] has quit [Ping timeout: 258 seconds]20:04
-!- sanuj [~sanuj@59.97.245.21] has joined #shogun20:17
-!- c4goldsw [5da420e6@gateway/web/cgi-irc/kiwiirc.com/ip.93.164.32.230] has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]20:24
-!- sanuj [~sanuj@59.97.245.21] has quit [Remote host closed the connection]20:42
--- Log closed Wed Jul 27 00:00:39 2016